add flag to enable PrometheusRule #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomassatka
requested review from
aaron-steinfeld,
laxmanchekka,
ravisingal and
tim-mwangi
as code owners
ravisingal
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, motivation and context.
Prometheus rule was enabled whenever the Cabapability was present on cluster. However sometimes we want more granular control to disable prometheus rule if we dont want to enable prometheus in first place therefore i see the connection with the flag.
Testing
Locally tried
helm templateChecklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.