Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cartesian bar #2562

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Cartesian bar #2562

wants to merge 10 commits into from

Conversation

anandtiwary
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@anandtiwary anandtiwary changed the base branch from main to cartesian-explore-changes December 5, 2023 07:29
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 70 lines in your changes are missing coverage. Please review.

Comparison is base (cf7c36a) 81.74% compared to head (c0503ae) 70.80%.

Files Patch % Lines
...mponents/cartesian/d3/data/series/cartesian-bar.ts 13.04% 59 Missing and 1 partial ⚠️
...d/components/cartesian/d3/chart/cartesian-chart.ts 18.18% 8 Missing and 1 partial ⚠️
...red/components/cartesian/d3/axis/cartesian-axis.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2562       +/-   ##
===========================================
- Coverage   81.74%   70.80%   -10.95%     
===========================================
  Files         929      930        +1     
  Lines       20854    20932       +78     
  Branches     3152     3162       +10     
===========================================
- Hits        17048    14820     -2228     
- Misses       3665     5855     +2190     
- Partials      141      257      +116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 5, 2023

Test Results

    4 files  ±0    317 suites  ±0   33m 8s ⏱️ +36s
1 143 tests ±0  1 142 ✅  - 1  0 💤 ±0  1 ❌ +1 
1 153 runs  ±0  1 152 ✅  - 1  0 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit c0503ae. ± Comparison against base commit cf7c36a.

♻️ This comment has been updated with latest results.

Base automatically changed from cartesian-explore-changes to main December 7, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant