Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix regex should match ${k1}_${k2}... #80

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kamaleshnneerasa
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

saxenakshitiz
saxenakshitiz previously approved these changes Nov 8, 2021
@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #80 (fd31ac3) into main (777df10) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #80   +/-   ##
=========================================
  Coverage     84.20%   84.20%           
  Complexity      308      308           
=========================================
  Files            38       38           
  Lines          1519     1519           
  Branches         45       45           
=========================================
  Hits           1279     1279           
  Misses          209      209           
  Partials         31       31           
Flag Coverage Δ
integration 84.20% <100.00%> (ø)
unit 83.37% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...fig/service/LabelApplicationRuleValidatorImpl.java 75.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 777df10...fd31ac3. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Nov 8, 2021

Unit Test Results

21 files  ±0  21 suites  ±0   37s ⏱️ -1s
78 tests ±0  78 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit fd31ac3. ± Comparison against base commit 777df10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants