Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo and improve error message in ripple writer #251

Merged
merged 3 commits into from
May 23, 2024

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Apr 15, 2024

Progress of the PR

  • Fix typo and improve error message in ripple writer,
  • [n/a] update docstring (if appropriate),
  • [n/a] update user guide (if appropriate),
  • add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:rosettasciio build of this PR (link in github checks)
  • [n/a] add tests,
  • ready for review.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.23%. Comparing base (46c5c5b) to head (09ce2ac).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
- Coverage   86.36%   86.23%   -0.14%     
==========================================
  Files          83       83              
  Lines       10652    10653       +1     
  Branches     2322     2322              
==========================================
- Hits         9200     9187      -13     
- Misses        935      949      +14     
  Partials      517      517              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rsciio/ripple/_api.py Outdated Show resolved Hide resolved
upcoming_changes/251.bugfix.rst Outdated Show resolved Hide resolved
@ericpre ericpre merged commit a7327e4 into hyperspy:main May 23, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants