-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s.save docstring: for write_dataset parameter add zspy #3203
base: RELEASE_next_minor
Are you sure you want to change the base?
s.save docstring: for write_dataset parameter add zspy #3203
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## RELEASE_next_major #3203 +/- ##
======================================================
+ Coverage 81.22% 84.11% +2.89%
======================================================
Files 173 197 +24
Lines 24164 32718 +8554
Branches 5618 8883 +3265
======================================================
+ Hits 19626 27521 +7895
- Misses 3247 3615 +368
- Partials 1291 1582 +291 ☔ View full report in Codecov by Sentry. |
@magnunor it would be worth adding a test for this just to make sure. I think I've tested it a couple of time with varying results? |
cb058cc
to
6f12b24
Compare
Based on rosettaio, it seems like this is already tested for: https://github.com/hyperspy/rosettasciio/blob/main/rsciio/tests/test_hspy.py#L924 I added a sentence about this only working with the default zspy file writer (DirectoryStore). |
As part of the split, this docstring needs to be changed, because as it is, it is not maintainable! Either it should refer to the rosettasciio docstring or pull all the arguments from the relevant function in rosettasciio. |
Re-opening because this has been closed automatically by mistake! |
When working with really large datasets, it is nice to change the metadata without having to rewrite the whole dataset.
Currently, the docstring only mentions
.hspy
but it seems to work for (at least) the default.zspy
(in other words, the folder structure one).However, I'm not sure if this will work for different zarr readers/writers.
Description of the change
.zspy
tos.save(write_dataset)
parameter.@CSSFrancis