-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metadata convention #3093
base: RELEASE_next_minor
Are you sure you want to change the base?
Conversation
Codecov ReportBase: 80.60% // Head: 80.60% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## RELEASE_next_major #3093 +/- ##
===================================================
Coverage 80.60% 80.60%
===================================================
Files 176 176
Lines 24476 24476
Branches 5383 5383
===================================================
Hits 19729 19729
Misses 3421 3421
Partials 1326 1326 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
In hyperspy/rosettasciio#89 (comment) it was suggested to actually migrate to the NeXus metadata convention for electron microscopy, developed in the meantime, instead of improving our custom-scheme. I'm copying in @sem-geologist @jordiferrero @CSSFrancis, as they were involved in the discussion in #2095. |
The main difference between the current proposal and the Nexus definition seems to be to me that the information I proposed to put in A rough overview is given in the following, though in the details the structure would need to be more thorougly revised. Current proposal, which tried to be more generic concerning type of experiment (e.g. allowing also a laser as source without using a different definition):
NeXus scheme (selected components), which is again more EM specific:
|
I am wondering if we should keep the metadata, as they are for HyperSpy 2.0 but plan for HyperSpy 3.0. Using the nexus definition for electron microscopy seems to be a very good option but it would take some time to do correctly. We need to get HyperSpy 2.0 released sooner than later and HyperSpy 3.0 could be focused solely on metadata changes. |
9203c67
to
aac2fea
Compare
Re-opening because this has been closed automatically by mistake! |
Description of the change
Adapt the metadata structure according to the discussion in #2095
Progress of the PR
upcoming_changes
folder (seeupcoming_changes/README.rst
),readthedocs
doc build of this PR (link in github checks)