Check signal specification conflicts #2445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpre
force-pushed
the
check_signal_specification_conflicts
branch
from
f456bc8
to
12fc1a2
Compare
|
Any risk of this conflicting with #2434? e.g. multiple warning messages or one branch of code never being called? |
|
That's waiting on hyperspy/hyperspy-extensions-list#2 so hopefully there's no circular dependency!! |
…_signal_specification_conflicts # Conflicts: # hyperspy/io.py
tjof2
reviewed
Jul 22, 2020
|
|
||
| if not isinstance(signal_dimension, int): | ||
| raise ValueError(f'Data type "{dtype.name}" not understood!') | ||
| if not isinstance(signal_dimension, int) or signal_dimension < 0: | ||
| raise ValueError("signal_dimension must be an interger") |
There was a problem hiding this comment.
Typo "integer". Also worth saying it must be >= 0?
Codecov Report
@@ Coverage Diff @@
## RELEASE_next_minor #2445 +/- ##
======================================================
- Coverage 74.15% 74.13% -0.02%
======================================================
Files 197 197
Lines 27889 27905 +16
Branches 6042 6046 +4
======================================================
+ Hits 20681 20688 +7
- Misses 5498 5506 +8
- Partials 1710 1711 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For hyperspy/hyperspy-extensions-list#3, I think when we add an package to the extension list, it would be useful to check if this package introduce signal specifications conflicts. I will add tests and update the dev guide if we agree on the approach.
Progress of the PR