-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion: Hyperspy metadata SEM vs TEM #2095
Comments
Good point. |
We're discussing metadata for luminescence spectroscopy in LumiSpy/lumispy#53 and come to a similar conclusion as here. The metadata structure seems to date from a time where EELS and EDX in TEM were the only applications. The overall structure is not so adapted to what HyperSpy wants to be nowadays, open to different instrument types and methods. So maybe, we should think of a reorganisation here @ericpre @francisco-dlp @jordiferrero |
Again, additional problem with this clumsy metadata structure can be experienced when loading msa files produced with DTSA-II, which contains data_type='EDS'. Is there any EDS system which knows if it is installed in TEM or SEM at all? |
I think the metadata structure should become something like we did for LumiSpy: The basic idea is to split detection and excitation, as it would more versatile when different instruments can be used for excitation, but the types of detectors that can be used are the same.
|
Ad 1.:
|
Ad 2.:
|
Ad 3.:
|
I would favor 3, as it is the most versatile and concise solution -- leaving out a lot of unneccesary nodes, while all the information will be contained. |
Alternative to |
Is this something worth discussing/implementing within the first version of RosettaSciIO #1978? |
Yes, that is why I added it to the HyperSpy v2.0 discussion: #2996 The convention is HyperSpy, though parsing is done in rosettasciio, but if we want to change anything the split would be the right moment to do so! |
So what are the action points for this @jlaehne?
Anything else? |
Added one more check. For the new metadata standard, we would first need an oppinion from more people, in particular @ericpre and @francisco-dlp. If we break it once, we should do it right ;-) |
I don't have anything to add except for to ping @jat255 as well. I know he works a lot with metadata so he might have some experience/good ideas for standardizing how we deal with metadata. |
As a sidenote, number 3 is somewhat similar as to how it is in handled in the NeXus applications definitions: https://manual.nexusformat.org/classes/applications/index.html#application-definitions |
Source and detection sounds better than current situation. I however would go one step further and divide the metadastructure into 3 not 2 parts. That would be |
Yes indeed, putting the However, currently we already have |
@ericpre @francisco-dlp it would be valuable to have your opinion on this proposal before starting to implement it. On the HyperSpy side, this should not be too much effort, but the refactoring of rsciio plugins to correctly handle the new metadata structure would be a little more effort due to the number of formats we already support. However, in view of us aiming at a more general audience, I think a more generic and less EM-specific metadata structure there would be really valuable and worth the effort. |
Moving back to the Discussion milestone, as this is not realistic for the 2.0 release. |
It is probably not an issue to most of the users, but I find the current hyperspy metadata structure to be a bit clumsy. My main issue is with SEM and TEM leafs. These are like singletons. It makes the tree unnecessary more complicated and adds additional level of depth. I have not seen even a single case, where acquisition instrument would have both SEM and TEM (and EELS and EDS under both of these). I think simplifying the tree structure would simplify parsing of files (particularly Bruker files where are no information about what kind of instrument the EDX detector is mounted on). SEM or TEM leaf could be refactored into simple attribute. i.e.
Acquisition_instrument.microscope_type
. The children of SEM/TEM could be moved one level up in the tree. Would this be possible in next_major version?The text was updated successfully, but these errors were encountered: