Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support regular urls that have a path component #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pferruggiaro
Copy link
Contributor

Constructs the Location.path based on the URL.host + URL.path, so that URLs such as scheme://callback/path are supported.

@mention-bot
Copy link

@pferruggiaro, thanks for your PR! By analyzing the history of the files in this pull request, we identified @onmyway133, @vadymmarkov and @zenangst to be potential reviewers.

@zenangst
Copy link
Contributor

zenangst commented Nov 8, 2016

This is great, thanks @pferruggiaro.

What do you guys think @hyperoslo/ios

@vadymmarkov
Copy link
Contributor

I like it @pferruggiaro

@onmyway133
Copy link
Contributor

Last time we support delimiter https://github.com/hyperoslo/Compass/blob/master/Sources/Compass.swift#L12 so that people don't have to to use the default :

@pferruggiaro is this what you mean?

@pferruggiaro
Copy link
Contributor Author

@onmyway133 Possibly...
I can see how switching the delimiter to / would enable a URL like user/list/{userId}/{kind}, but my goal is to support a standard URL that includes a host, path, and query params such as targetapp://x-callback-url/updateStatus?x-source=SourceApp&text=test123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants