New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding GroupKFold and testing it #200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting these initial changes for it to go through the automated testing.
Once it gets through, Ill take a closer look
Thank you for your review. I applied all the suggestions. Co-authored-by: mandjevant <38689620+mandjevant@users.noreply.github.com>
apply the review Co-authored-by: mandjevant <38689620+mandjevant@users.noreply.github.com>
@mandjevant |
Thank you for your contribution! Thus, I suppressed the rule on (only) that line by adding a comment stating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition, please change
n_folds: int, default is None
When n_folds is not None, use K-fold cross-validation when
n_folds > 2. Or, use leave-one-out cross-validation when
n_folds = -1.
to
n_folds: int, default is None
When n_folds is not None, use K-fold cross-validation when
n_folds > 2. Or, use leave-one-out cross-validation when
n_folds = -1. For Group K-fold cross-validation, functions as
`n_splits`.
In both places:
Function and test case look appropriate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for your contribution!
@bjkomer Any thoughts?
Ill go ahead and merge this. Thank you for your contribution @hyun-seo |
Referring to #157, there is an issue about group cross-validation.
This pull request implementation this issue by adding new argument
kfolds_group
andusing
sklearn.model_selection.GroupKFold
.