Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix with_coverage, isolate not unstable but extra_functional #4573

Merged
merged 2 commits into from May 14, 2024

Conversation

s8sato
Copy link
Contributor

@s8sato s8sato commented May 9, 2024

Description

  1. redefine with_coverage step to exclude client integration tests
    • and to include p2p integration tests
  2. expand the exception of the client integration tests from unstable_network to extra_functional

Linked issue

  1. closes Fix with_coverage #4488 (comment)
  2. sometimes integration step fails due to some flaky extra_functional tests

Benefits

  1. isolation of flaky tests more in line with current realities

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@s8sato s8sato marked this pull request as ready for review May 10, 2024 07:51
@s8sato s8sato marked this pull request as draft May 10, 2024 09:02
@s8sato s8sato changed the title ci: by command, exclude client integration tests from coverage ci: restore with_coverage, isolate not unstable_network but extra_functional May 10, 2024
@s8sato s8sato changed the title ci: restore with_coverage, isolate not unstable_network but extra_functional ci: restore with_coverage, isolate not unstable but extra_functional May 10, 2024
@s8sato s8sato marked this pull request as ready for review May 10, 2024 11:48
@s8sato s8sato added the CI label May 10, 2024
@s8sato s8sato changed the title ci: restore with_coverage, isolate not unstable but extra_functional ci: fix with_coverage, isolate not unstable but extra_functional May 10, 2024
nxsaken
nxsaken previously approved these changes May 13, 2024
.github/workflows/iroha2-dev-pr.yml Outdated Show resolved Hide resolved
.github/workflows/iroha2-dev-pr.yml Outdated Show resolved Hide resolved
Signed-off-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
Signed-off-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
@mversic mversic merged commit f361dd9 into hyperledger:main May 14, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix with_coverage
3 participants