Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Use multihash format for private keys #4541

Merged
merged 2 commits into from May 7, 2024
Merged

refactor!: Use multihash format for private keys #4541

merged 2 commits into from May 7, 2024

Conversation

dima74
Copy link
Contributor

@dima74 dima74 commented May 2, 2024

Description

Added support for encoding/decoding private keys to multihash module, and replaced each occurence of PRIVATE_KEY_ALGORITHM/PRIVATE_KEY_PAYLOAD pair to PRIVATE_KEY in multihash format

Linked issue

Closes #4412

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@dima74 dima74 marked this pull request as ready for review May 2, 2024 12:13
@github-actions github-actions bot added the config-changes Changes in configuration and start up of the Iroha label May 2, 2024
@dima74 dima74 requested review from s8sato and mversic as code owners May 2, 2024 12:13
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

@BAStos525

@dima74
refactor!: Use multihash format for private keys (hyperledger#4412)
6d6a659 
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
Erigara
Erigara approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@Erigara Erigara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good impovment in readability of private key

@0x009922 0x009922 self-assigned this May 7, 2024
0x009922
0x009922 approved these changes May 7, 2024
View reviewed changes
tools/swarm/src/compose.rs Show resolved Hide resolved
@0x009922
Copy link
Contributor

0x009922 commented May 7, 2024

Looking forward to merge it soon, so that I can rebase #4456 on top of it.

@mversic mversic merged commit b00e102 into hyperledger:main May 7, 2024
11 of 14 checks passed
@dima74 dima74 deleted the multihash-private-key branch May 7, 2024 12:03
@mversic mversic mentioned this pull request May 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mversic mversic mversic left review comments

@Erigara Erigara Erigara approved these changes

@0x009922 0x009922 0x009922 approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@VAmuzing VAmuzing Awaiting requested review from VAmuzing VAmuzing is a code owner

@Asem-Abdelhady Asem-Abdelhady Awaiting requested review from Asem-Abdelhady

Assignees

@dima74 dima74

@Erigara Erigara

@0x009922 0x009922

Labels
config-changes Changes in configuration and start up of the Iroha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[suggestion] Adopt multihash format for private keys
4 participants
@dima74 @0x009922 @Erigara @mversic