Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] #4331: Revoke removed PermissionTokens on Upgrade<Executor> #4503

Merged
merged 1 commit into from May 1, 2024

Conversation

dima74
Copy link
Contributor

@dima74 dima74 commented Apr 23, 2024

Description

If some permission token was removed from schema during executor migration, then revoke that permission token from related roles and accounts.

Linked issue

Closes #4331

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Apr 23, 2024
Copy link
Contributor

@Erigara Erigara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please ping after picking free port

client/tests/integration/upgrade.rs Outdated Show resolved Hide resolved
@dima74 dima74 force-pushed the upgrade-executor-revoke-tokens branch from d701f63 to e274741 Compare April 24, 2024 10:19
…<Executor>`

Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
@mversic mversic force-pushed the upgrade-executor-revoke-tokens branch from e274741 to 36bbcbd Compare May 1, 2024 09:42
Copy link

github-actions bot commented May 1, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification, and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[fix] #4331: Revoke removed `PermissionToken`s on `Upgrade<Executor>`". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@mversic mversic merged commit 0a936c3 into hyperledger:main May 1, 2024
9 of 13 checks passed
@dima74 dima74 deleted the upgrade-executor-revoke-tokens branch May 2, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revoke PermissionTokens on Upgrade<Executor>
3 participants