refactor: Transactional trigger set #4489
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erigara
added
iroha2-dev
Erigara
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
0x009922,
DCNick3,
VAmuzing,
Asem-Abdelhady and
dima74
as code owners
mversic
force-pushed
the
transactional_trigger_set
branch
from
bbcffc0
to
422db59
Compare
dima74
previously approved these changes
May 7, 2024
Erigara
force-pushed
the
transactional_trigger_set
branch
2 times, most recently
from
38e3c91
to
d1dc4ed
Compare
Erigara
changed the title
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara
force-pushed
the
transactional_trigger_set
branch
from
d1dc4ed
to
77af259
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
As for WSV, make trigger set make trigger set transactional.
Issues
Closes #4378
Benefits
For large amount of triggers and frequent trigger execution transactional model allow not to clone trigger set all the time saving time and space.
Possible Drawbacks
Might be not so efficient when there is small amount of triggers.