Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #4093, #4110: Add public key mint and burn commands to iroha_client_cli #4408

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nxsaken
Copy link
Contributor

@nxsaken nxsaken commented Apr 4, 2024

Description

  • Add a client CLI command for adding a new signatory to an account (minting a public key for an account).
  • Add a client CLI command for burning a public key from an account.

Linked issue

Closes #4093 and #4110.

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
@nxsaken nxsaken self-assigned this Apr 4, 2024
@github-actions github-actions bot added Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Apr 4, 2024
…roha_client_cli`

Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
@DCNick3
Copy link
Contributor

DCNick3 commented Apr 4, 2024

Is there a reason why minting a key for account is in the account subcommand, but burning is in an entirely new one?

@nxsaken
Copy link
Contributor Author

nxsaken commented Apr 4, 2024

I simply went with the formats described in the respective issues. They probably should be under the same subcommand, but I wanted to get feedback first.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this work will be reverted by the 1st PR for #2085 in progress, which makes an account have a single public key in its ID

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean the issues this PR addresses are obsolete?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This is an unfortunate conflict, but after opening the PR I will check if the open issues are still valid

@s8sato s8sato self-assigned this Apr 4, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8550778779

Details

  • 0 of 24 (0.0%) changed or added relevant lines in 1 file are covered.
  • 5346 unchanged lines in 95 files lost coverage.
  • Overall coverage increased (+0.9%) to 57.644%

Changes Missing Coverage Covered Lines Changed/Added Lines %
client_cli/src/main.rs 0 24 0.0%
Files with Coverage Reduction New Missed Lines %
primitives/src/conststr.rs 1 91.14%
crypto/src/hash.rs 1 73.78%
ffi/derive/src/convert.rs 1 84.45%
primitives/src/lib.rs 1 0.0%
core/src/sumeragi/network_topology.rs 1 98.78%
primitives/src/must_use.rs 2 74.29%
crypto/src/signature/bls/mod.rs 2 0.0%
config/src/snapshot.rs 3 78.57%
data_model/derive/src/has_origin.rs 3 95.16%
config/src/kura.rs 3 80.0%
Totals Coverage Status
Change from base Build 7884695009: 0.9%
Covered Lines: 23491
Relevant Lines: 40752

💛 - Coveralls

@nxsaken nxsaken changed the base branch from iroha2-dev to main April 16, 2024 08:34
@nxsaken nxsaken requested a review from dima74 as a code owner April 16, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants