New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[poc] DO NOT MERGE: shared account ID is off curve #4371
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
use super::{PublicKey, Signatories}; | ||
|
||
/// Opaque bytes interpreted to either personal or shared account ID. | ||
type RawId = [u8; 32]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha, really suspicious
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we, please, not include shared accounts in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a PR, but how multi-signatory account holds its ID will soon become important.
Since this is still intended to be a compliant proposal to the discussion so far, could you be more specific about the issue or provide an alternative?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you just advised not to preemptively implement shared accounts in the 1st PR. If so, we are on the same page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If so, this PoC should be entirely re-written? I see the code is mostly about shared accounts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this PoC is a part of the specification or discussion, and is completely different from the 1st PR.
So this is expected to be closed at some point
Description
Linked issue
Benefits
Checklist
CONTRIBUTING.md