[refactor] #4039: Enhance ClientCli Wait Mechanism for Transaction Completion in pytests and Remove Fixed Sleeps

[AlexStroke]

Description

Linked issue

Closes #{issue_number}

Benefits

Checklist

• I've read CONTRIBUTING.md
• I've used the standard signed-off commit format (or will squash just before merging)
• All applicable CI checks pass (or I promised to make them pass later)
• (optional) I've written unit tests for the code changes
• I replied to all comments after code review, marking all implemented changes with thumbs up

[coveralls]

Pull Request Test Coverage Report for Build 8555785955

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 5346 unchanged lines in 95 files lost coverage.
• Overall coverage increased (+0.9%) to 57.676%

---

Files with Coverage Reduction	New Missed Lines	%
primitives/src/conststr.rs	1	91.14%
crypto/src/hash.rs	1	73.78%
ffi/derive/src/convert.rs	1	84.45%
primitives/src/lib.rs	1	0.0%
core/src/sumeragi/network_topology.rs	1	98.78%
primitives/src/must_use.rs	2	74.29%
crypto/src/signature/bls/mod.rs	2	0.0%
config/src/snapshot.rs	3	78.57%
data_model/derive/src/has_origin.rs	3	95.16%
config/src/kura.rs	3	80.0%

Totals
Change from base Build 7884695009:	0.9%
Covered Lines:	23491
Relevant Lines:	40729

---

💛 - Coveralls

[Erigara]

listen_to_events expects config_path but you are passing port here, looks suspicious

[Erigara]

I don't think you need a lock here, python dict is thread-safe due to GIL.

[Erigara]

Instead of default dict you can use deafultdict(str) here, this way code could be simplified:

Suggested change

	if config_path in self.event_data:
	self.event_data[config_path] += output
	else:
	self.event_data[config_path] = output
	self.event_data[config_path] += output

[Erigara]

This part looks like every thread will see only latest call to update_torii_url.

[github-actions]

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification, and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[refactor] #4039: Enhance ClientCli Wait Mechanism for Transaction Completion in pytests and Remove Fixed Sleeps ". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit