[fix] #4311: fix pre-commit hook

[Asem-Abdelhady]

Description

the pre-commit hook still generates the genesis in peer even though it does not exist anymore after the big change in the configuration

Linked issue

Closes #4311

Checklist

• I've read CONTRIBUTING.md
• I've used the standard signed-off commit format (or will squash just before merging)
• All applicable CI checks pass (or I promised to make them pass later)
• (optional) I've written unit tests for the code changes
• I replied to all comments after code review, marking all implemented changes with thumbs up

[Arjentix]

Why Iroha 1 CI was triggered...?

[s8sato]

I've wanted to check this hook as it's been a while since my last contribution.
I think someone's working example of .git/hooks/pre-commit would help

[Arjentix]

I think someone's working example of .git/hooks/pre-commit would help

I don't use pre-commit hook but here is

Some commands from my .vscode/tasks.json

      {
          "label": "regenerate genesis",
          "type": "shell",
          "problemMatcher": [],
          "presentation": {
              "clear": true
          },
          "command": "cargo",
          "args": [
              "run",
              "--release",
              "--bin",
              "kagami",
              "--",
              "genesis",
              "--executor-path-in-genesis=./executor.wasm",
              ">",
              "${workspaceFolder}/configs/swarm/genesis.json",
          ],
      },
      {
          "label": "regenerate executor",
          "type": "shell",
          "problemMatcher": [],
          "presentation": {
              "clear": true
          },
          "command": "cargo",
          "args": [
              "run",
              "--release",
              "--bin",
              "iroha_wasm_builder_cli",
              "--",
              "build",
              "${workspaceFolder}/default_executor",
              "--optimize",
              "--outfile",
              "${workspaceFolder}/configs/swarm/executor.wasm",
          ],
      },
      {
          "label": "regenerate schema",
          "type": "shell",
          "problemMatcher": [],
          "presentation": {
              "clear": true
          },
          "command": "cargo",
          "args": [
              "run",
              "--release",
              "--bin",
              "kagami",
              "--",
              "schema",
              ">",
              "${workspaceFolder}/docs/source/references/schema.json",
          ],
      },
      {
          "label": "regenerate docker compose single",
          "type": "shell",
          "problemMatcher": [],
          "presentation": {
              "clear": true
          },
          "command": "cargo",
          "args": [
              "run",
              "--release",
              "--bin",
              "iroha_swarm",
              "--",
              "-p",
              "1",
              "-s",
              "Iroha",
              "--force",
              "--config-dir",
              "./configs/swarm",
              "--health-check",
              "--build",
              ".",
              "--outfile",
              "configs/swarm/docker-compose.single.yml"
          ],
      },
      {
          "label": "regenerate docker compose multiple",
          "type": "shell",
          "problemMatcher": [],
          "presentation": {
              "clear": true
          },
          "command": "cargo",
          "args": [
              "run",
              "--release",
              "--bin",
              "iroha_swarm",
              "--",
              "-p",
              "4",
              "-s",
              "Iroha",
              "--force",
              "--config-dir",
              "./configs/swarm",
              "--health-check",
              "--build",
              ".",
              "--outfile",
              "configs/swarm/docker-compose.local.yml"
          ],
      },
      {
          "label": "regenerate docker compose default",
          "type": "shell",
          "problemMatcher": [],
          "presentation": {
              "clear": true
          },
          "command": "cargo",
          "args": [
              "run",
              "--release",
              "--bin",
              "iroha_swarm",
              "--",
              "-p",
              "4",
              "-s",
              "Iroha",
              "--force",
              "--config-dir",
              "./configs/swarm",
              "--health-check",
              "--image",
              "hyperledger/iroha2:dev",
              "--outfile",
              "configs/swarm/docker-compose.yml"
          ],
      },
      {
          "label": "regenerate all",
          "type": "shell",
          "problemMatcher": [],
          "presentation": {
              "clear": true
          },
          "dependsOn": [
              "regenerate genesis",
              "regenerate schema",
              "regenerate executor",
              "regenerate docker compose single",
              "regenerate docker compose multiple",
              "regenerate docker compose default",
          ]
      },

[s8sato]

Or we could just run locally as same consistency checks as CI does:

iroha/.github/workflows/iroha2-dev-pr.yml

Lines 28 to 36 in 41c08b4

	- name: Check genesis.json
	if: always()
	run: ./scripts/tests/consistency.sh genesis
	- name: Check schema.json
	if: always()
	run: ./scripts/tests/consistency.sh schema
	- name: Check Docker Compose configurations
	if: always()
	run: ./scripts/tests/consistency.sh docker-compose

I basically think it's up to each developer to avoid failures on push, but as long as pre-commit.sample is referred in CONTRIBUTING.md it needs to be maintained and represent some consensus on pre-commit:

iroha/CONTRIBUTING.md

Line 26 in 4de547f

- Perform pre-commit routine like formatting & artifacts regeneration (see [`pre-commit.sample`](./hooks/pre-commit.sample))

[0x009922]

Also:

• [discussion] Rename configs/swarm? #4293

[mversic]

@Asem-Abdelhady let's finish this PR

[Asem-Abdelhady]

Also:

• [discussion] Rename configs/swarm? #4293

Pp till now it is not changed so we can modify it if we decided to go with the change. Unless you want me to change it in this PR of course but I suggest this should be done in a separate PR.

[s8sato]

The purpose of the original issue has been reached, though, I'd make it one that ensures everything is up to date i.e. add updates to executor and docker compose files.
#4313 (comment) would help for it

The base branch was changed.