New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] #3901: delete NewParameter isi and use only SetParameter #4310
Draft
Asem-Abdelhady
wants to merge
1
commit into
hyperledger:main
Choose a base branch
from
Asem-Abdelhady:remove-newParameter-isi
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[refactor] #3901: delete NewParameter isi and use only SetParameter #4310
Asem-Abdelhady
wants to merge
1
commit into
hyperledger:main
from
Asem-Abdelhady:remove-newParameter-isi
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
label
Feb 21, 2024
Pull Request Test Coverage Report for Build 8000907676Details
💛 - Coveralls |
Asem-Abdelhady
force-pushed
the
remove-newParameter-isi
branch
from
February 21, 2024 07:25
fd6063e
to
29583ce
Compare
mversic
reviewed
Feb 21, 2024
mversic
reviewed
Feb 21, 2024
Asem-Abdelhady
force-pushed
the
remove-newParameter-isi
branch
2 times, most recently
from
February 21, 2024 08:09
a7e0ff0
to
7ebbbae
Compare
we need a test that shows how we can create a new parameter in executor and then update it's value |
Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
Asem-Abdelhady
force-pushed
the
remove-newParameter-isi
branch
from
February 22, 2024 07:27
7ebbbae
to
cab1f17
Compare
github-actions
bot
added
api-changes
Changes in the API for client libraries
config-changes
Changes in configuration and start up of the Iroha
labels
Feb 22, 2024
s8sato
removed
the
config-changes
Changes in configuration and start up of the Iroha
label
Feb 26, 2024
let's say that we want to define a parameter like |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api-changes
Changes in the API for client libraries
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NewParameter
is only used during genesis generation. it does not make sense to have it as ISI. Now the admin will generate the parameters during configuration and he can give permessions for other users to allow them to put parameters.Linked issue
Closes #3901
Checklist
CONTRIBUTING.md