Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[documentation] #4234: Iroha 2 README YAC #4235

Merged
merged 2 commits into from Apr 29, 2024
Merged

[documentation] #4234: Iroha 2 README YAC #4235

merged 2 commits into from Apr 29, 2024

Conversation

6r1d
Copy link
Contributor

@6r1d 6r1d commented Jan 24, 2024 •
edited

A one-liner solution for #4234:

It seems I1 README is being displayed. I intend to add a small link to iroha.tech and ignore a whitepaper as it may be revised.

WRRicht3r
WRRicht3r previously approved these changes Jan 24, 2024
View reviewed changes
outoftardis
outoftardis previously approved these changes Jan 24, 2024
View reviewed changes
yamkovoy
yamkovoy reviewed Jan 24, 2024
View reviewed changes
Copy link
Contributor

@yamkovoy yamkovoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small suggestion.

yamkovoy
yamkovoy requested changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@yamkovoy yamkovoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Unified the wording.
  • Replaced "-" with "—".

yamkovoy
yamkovoy requested changes Jan 24, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@6r1d 6r1d dismissed stale reviews from outoftardis and WRRicht3r via e86cc51 January 24, 2024 14:35
yamkovoy
yamkovoy previously approved these changes Jan 24, 2024
View reviewed changes
@mversic mversic added the 1.x label Jan 29, 2024
baziorek
baziorek previously approved these changes Jan 29, 2024
View reviewed changes
@nxsaken nxsaken dismissed stale reviews from baziorek and yamkovoy April 16, 2024 08:27

The merge-base changed after approval.

@nxsaken nxsaken changed the base branch from main to iroha1-main April 16, 2024 08:30
6r1d and others added 2 commits April 29, 2024 11:25
@6r1d @nxsaken
[documentation] #4234: Iroha 2 README YAC
a1e89a8 
Signed-off-by: 6r1d <vic.6r1d@gmail.com>
@6r1d @yamkovoy @nxsaken
Update README.md
6f1ddc8 
Co-authored-by: yamkovoy <100563712+yamkovoy@users.noreply.github.com>
Signed-off-by: Victor <vic.6r1d@gmail.com>
@nxsaken nxsaken merged commit bf6e22a into iroha1-main Apr 29, 2024
22 of 23 checks passed
@nxsaken nxsaken mentioned this pull request Apr 29, 2024
Closed
@mversic mversic deleted the yac_replacement branch April 29, 2024 07:39
@nxsaken nxsaken added the iroha1 The legacy version of Iroha. label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baziorek baziorek baziorek left review comments

@yamkovoy yamkovoy yamkovoy left review comments

@outoftardis outoftardis Awaiting requested review from outoftardis

@WRRicht3r WRRicht3r Awaiting requested review from WRRicht3r

@s8sato s8sato Awaiting requested review from s8sato

@mversic mversic Awaiting requested review from mversic

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@Erigara Erigara Awaiting requested review from Erigara

@0x009922 0x009922 Awaiting requested review from 0x009922

@DCNick3 DCNick3 Awaiting requested review from DCNick3

@VAmuzing VAmuzing Awaiting requested review from VAmuzing

@Asem-Abdelhady Asem-Abdelhady Awaiting requested review from Asem-Abdelhady

@dima74 dima74 Awaiting requested review from dima74

Assignees
No one assigned
Labels
1.x iroha1 The legacy version of Iroha.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@6r1d @baziorek @outoftardis @WRRicht3r @yamkovoy @nxsaken @mversic