Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[suggestion] Move NewParameter into Executor #3901

Open
mversic opened this issue Sep 20, 2023 · 3 comments · May be fixed by #4513
Open

[suggestion] Move NewParameter into Executor #3901

mversic opened this issue Sep 20, 2023 · 3 comments · May be fixed by #4513
Assignees
@dima74
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Milestone
2.0.0-rc.1.0

Comments

@mversic
Copy link
Contributor

mversic commented Sep 20, 2023

We should consider removing NewParameter ISI and only allow defining new parameters in Executor. During Executor migration old parameters will be removed and new ones can be added. The reason is that having an ISI doesn't make sense for an operation that can only be executed by the blockchain admin
@mversic mversic added iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested labels Sep 20, 2023
@Arjentix
Copy link
Contributor

I think that would be right

@ilchu ilchu self-assigned this Nov 14, 2023
@mversic mversic removed the question Further information is requested label Jan 4, 2024
@ilchu ilchu removed their assignment Jan 12, 2024
@Asem-Abdelhady Asem-Abdelhady mentioned this issue Feb 21, 2024
Draft
5 tasks
@mversic mversic mentioned this issue Apr 17, 2024
Open
@mversic mversic assigned dima74 and unassigned Asem-Abdelhady Apr 24, 2024
@mversic mversic added this to the 2.0.0-rc.1 milestone Apr 24, 2024
dima74 added a commit to dima74/iroha that referenced this issue Apr 25, 2024
@dima74
[refactor] hyperledger#3901: Move NewParameter into Executor
8d62192 
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
dima74 added a commit to dima74/iroha that referenced this issue Apr 25, 2024
@dima74
[refactor] hyperledger#3901: Add method to define parameter in execut…
41c2be8 
…or `migrate` entrypoint

Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
@dima74 dima74 linked a pull request Apr 25, 2024 that will close this issue
Draft
5 tasks
@0x009922
Copy link
Contributor

0x009922 commented May 8, 2024

What means "move NewParameter into Executor"?

As far as I understand, Executor just has access to all parameters, to the key-value storage with some data. And, Executor just "interprets" certain keys in a certain way which defines Executor's behaviour.

Is it needed for Executor to define "known" parameters in some way?

@mversic
Copy link
Contributor Author

mversic commented May 8, 2024

just look at how permission tokens are defined in Executor. We need to replicate that mechanism

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dima74 dima74

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
2.0.0-rc.1.0
Development

Successfully merging a pull request may close this issue.

[refactor] #3901: Add method to define parameter in executor migrate entrypoint dima74/iroha
6 participants
@dima74 @ilchu @Arjentix @Asem-Abdelhady @0x009922 @mversic