Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] Adopt multihash format for private keys #4412

Open
0x009922 opened this issue Apr 10, 2024 · 2 comments · Fixed by #4541
Open

[suggestion] Adopt multihash format for private keys #4412

0x009922 opened this issue Apr 10, 2024 · 2 comments · Fixed by #4541
Assignees
Labels
config-changes Changes in configuration and start up of the Iroha crypto iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested

Comments

@0x009922
Copy link
Contributor

In configurations, we use the following format for public/private keys:

public_key = "ed012014A2900349A8CB6250D8CE5399D1964766B559A37F48E8C98C1EA83F365D8A72"
private_key = { algorithm = "ed25519", payload = "67AAB998A3951A071324B815BAF425309D6AF8D2D2636A3FC2BEA01C322BC23B14A2900349A8CB6250D8CE5399D1964766B559A37F48E8C98C1EA83F365D8A72" }

While multihash format is used for public_key, why can't we use it for the private one too?

It would make config more consistent and less confusing, and will also remove necessity to set private key in the environment through 2 split variables PRIVATE_KEY_ALGORITHM and PRIVATE_KEY_PAYLOAD.

@0x009922 0x009922 added question Further information is requested iroha2-dev The re-implementation of a BFT hyperledger in RUST config-changes Changes in configuration and start up of the Iroha crypto labels Apr 10, 2024
@Erigara
Copy link
Contributor

Erigara commented Apr 10, 2024

Sounds good to me, what are downsides?

@DCNick3
Copy link
Contributor

DCNick3 commented Apr 11, 2024

Same position here. Sounds good and doesn't seem to have any downsides on the first glance.

@dima74 dima74 self-assigned this Apr 26, 2024
dima74 added a commit to dima74/iroha that referenced this issue May 2, 2024
dima74 added a commit to dima74/iroha that referenced this issue May 2, 2024
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
dima74 added a commit to dima74/iroha that referenced this issue May 2, 2024
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
@dima74 dima74 reopened this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config-changes Changes in configuration and start up of the Iroha crypto iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants