Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ledger-browser): use react query in eth app #3207

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

outSH
Copy link
Contributor

@outSH outSH commented Apr 15, 2024

  • Use react query to fetch data instead of manual fetches.
  • Remove dead / duplicated code where applicable.
  • Minor refactors and fixes.

Depends on #3203

Signed-off-by: Michal Bajer michal.bajer@fujitsu.com

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

- Add dynamic routing based on configuration instead of hardcoded one.
- Add MUI and configure custom theme.
    Use this new UI kit to create app better bar and ledger selector.
- Cleanup common application code.
- Add sample SQL data to quickly test the GUI
    without running persistence plugins.

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
- Use react query to fetch data instead of manual fetches.
- Remove dead / duplicated code where applicable.
- Minor refactors and fixes.

Depends on hyperledger#3203

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
Copy link

This PR/issue depends on:

outSH added a commit to outSH/cactus that referenced this pull request Apr 25, 2024
- Refactor ETH app dashboard using MUI components.
- Fix ERC20 details page rendering.
- Add block and transaction list components that use common `UITableListing`.
- Add global notifications that will be displayed in a snackbar.

Depends on hyperledger#3207

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant