Reftests 13.3 / EIP-7610 implementation #7055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade reftests to 13.3 * Implement retroactive EIP-7610 We need to do both of these at once as the reference tests needed to be updated to reflect the changes in the retroactive EIP. Signed-off-by: Danno Ferrin <danno@numisight.com>
* Upgrade reftests to 13.3 * Implement retroactive EIP-7610 We need to do both of these at once as the reference tests needed to be updated to reflect the changes in the retroactive EIP. Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Danno Ferrin <danno@numisight.com>
fab-10
pushed a commit
that referenced
this pull request
May 8, 2024
* Upgrade reftests to 13.3 * Implement retroactive EIP-7610 We need to do both of these at once as the reference tests needed to be updated to reflect the changes in the retroactive EIP. EIPTests for prague are disabled as they are still in flux Signed-off-by: Danno Ferrin <danno@numisight.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
We need to do both of these at once as the reference tests needed to be
updated to reflect the changes in the retroactive EIP.
Signed-off-by: Danno Ferrin danno@numisight.com
Fixed Issue(s)
This does not fix #6984, even though there are reftests. The tests are disabled not only Besu doesn't implement the reftests, but because they were filled with a version of Prague that does not implement EIP-6110. Blockchain tests need to remain disabled until there is a 13.4 with 6110 or a 14.0 version.
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests