Verkle 645 #7004
Merged
Verkle 645 #7004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
…CodeChunks Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
refactor access witness code part Signed-off-by: Karim Taam <karim.t2am@gmail.com>
garyschulte
commented
Apr 29, 2024
Comment on lines
+53
to
54
| return gasCalculator().getBalanceOperationGasCost(frame, maybeAddress) | ||
| + (accountIsWarm |
There was a problem hiding this comment.
any reason not to be consistent and use clampedAdd ?
garyschulte
commented
Apr 29, 2024
| return gasCalculator().getExtCodeSizeOperationGasCost() | ||
| protected long cost( | ||
| final boolean accountIsWarm, final MessageFrame frame, final Optional<Address> maybeAddress) { | ||
| return gasCalculator().getExtCodeSizeOperationGasCost(frame, maybeAddress) |
There was a problem hiding this comment.
same, clampedAdd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)
Accumulated fixes to progress past block 645 on devnet-6.
reverts Shanghai and Prague Gas calculator changes
creates Eip4762 definition and calculator to consolidate prior gas calc changes
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests