Allow API configuration to override supplied gasLimit #6978
Conversation
| LOG.info("Capping gasLimit to " + gasCap); | ||
| } | ||
| gasLimit = rpcGasCap; | ||
| LOG.info("Capping gasLimit to " + rpcGasCap); |
There was a problem hiding this comment.
so no longer comparing gasCap to gasLimit, just if > zero?
There was a problem hiding this comment.
yes, it is essentially an override value from the cli. @matkt can speak to the specifics about why we would raise the cap beyond the requested limit, but I think it has something to do with simulating transactions that will exceed the anticipated gas, but not exceed some predefined hard cap (DoS vector).
There was a problem hiding this comment.
yes it is need in order to allow user setting a high gasLimit for ethcall
| @@ -565,8 +565,9 @@ public void shouldCapGasLimitWhenOriginalTransactionExceedsGasCap() { | |||
| } | |||
|
|
|||
| @Test | |||
| public void shouldKeepOriginalGasLimitWhenCapIsHigherThanOriginalValue() { | |||
| // generate a transaction with a gas limit that is lower than the gas cap | |||
| public void shouldUseRpcGasCapWhenCapIsHigherThanGasLimit() { | |||
There was a problem hiding this comment.
what if cap is lower than gasLimit
There was a problem hiding this comment.
yeah, this test can really just be renamed to something like "when present rpc gas cap supersedes request gas limit"
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
feature/configurable-simulation-tx-gas-limit
branch
from
f40d66c
to
c3e9cf3
Compare
garyschulte
added
the
doc-change-required
alexandratran
removed
the
doc-change-required
PR description
Allow API configuration to override supplied gasLimit. Originally this commit was part of #6641. Moved here for visibility and easier review.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests