Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates a new issue template for releases #6972

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jflo
Copy link
Contributor

@jflo jflo commented Apr 19, 2024

No description provided.

- this is now public and notifies subscribed users
- publishes artefacts and version-specific docker tags
- [ ] Using the same git sha, create a new tag for the FULL RELEASE, example format 24.4.0
- [ ] Using the FULL RELEASE tag, create a PRE-RELEASE in github to trigger the workflows
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean we get 2 pre-releases? one for the RC and one for the full release tag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is copypasta from @siladu but i interpreted it as using pre-release is optional for RCs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok fair enough. DCO is broken tho

Copy link
Contributor

@siladu siladu Apr 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the part I asked for feedback on.

This is also in flux due to #6963
Am currently testing out scenarios with this PR.

Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist has been updated in light of .#6963 (comment)

It will change again if and when we play #6994

Comment on lines +22 to +24
- [ ] Convert the DRAFT into a PRE-RELEASE
- this is now public and notifies subscribed users
- publishes artefacts and version-specific docker tags
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed this step from the WIP checklist as it would result in creating redundant 24.5.0-RC1 artefacts.

See #6963 (comment) for context.

Most of the time we will want to go straight from draft/burn-in -> full release, with pre-release being a necessary in-between step for now. That pre-release needs to use the full release tag e.g. 24.5.0 instead of 24.5.0-RC1.

- this is now public and notifies subscribed users
- publishes artefacts and version-specific docker tags
- [ ] Using the same git sha, create a new tag for the FULL RELEASE, example format 24.4.0
- [ ] Using the FULL RELEASE tag, create a PRE-RELEASE in github to trigger the workflows
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [ ] Using the FULL RELEASE tag, create a PRE-RELEASE in github to trigger the workflows
- [ ] Using the FULL RELEASE tag, create a PRE-RELEASE in github to trigger the workflows
- this is now public and notifies subscribed users
- publishes artefacts and version-specific docker tags

Moving extra comments from the removed step above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants