fix chain download halt #6969
Draft
fix chain download halt #6969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
|
great find. We recently discovered that the geth snap sync pipeline does something very similar. |
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
…he pivot header Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
… async Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
In some cases a syncing Besu node stopped downloading the chain data. The reason for that was that sometimes peers that were selected to download headers that are needed to allow the parallel download of the next batch of headers only returned one header instead of 200 headers.
There was a mechanism that restarted the pipeline for the chain download, but if the same peer was selected to do that initial download the same would happen again. In some cases that happened for a long time, making it noticeable, but it turned out that this happens for short periods of time as well (still slowing down the chain download process).
This PR adds a check that disconnects the peer only returning one block to make sure that a different peer is selected for the next restart of the pipeline.
Fixed Issue(s)
#6884