Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

confirm pivot block - removed disconnect based on chain height estimate #6889

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

confirm pivot block - removed disconnect based on chain height estimate #6889

wants to merge 23 commits into from

Commits on Apr 4, 2024

  1. gst 

    Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
    @macfarla
    macfarla committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    e64112f View commit details
    Browse the repository at this point in the history

  2. update chain height estimate of that peer to reflect reality 

    Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
    @macfarla
    macfarla committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    e44fcc2 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. log details on comparator update 

    Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
    @macfarla
    macfarla committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    da0454a View commit details
    Browse the repository at this point in the history

  2. use default comparator not chain height 

    Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
    @macfarla
    macfarla committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    9a374ab View commit details
    Browse the repository at this point in the history

  3. extra logging re best peer 

    Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
    @macfarla
    macfarla committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    77b9ea7 View commit details
    Browse the repository at this point in the history

  4. allow 1 trailing peer not zero 

    Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
    @macfarla
    macfarla committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    d01a423 View commit details
    Browse the repository at this point in the history

  5. removed check for chain height prior to confirming pivot block 

    Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
    @macfarla
    macfarla committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    500843d View commit details
    Browse the repository at this point in the history

  6. remove a log line that is repeated unnecessarily 

    Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
    @macfarla
    macfarla committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    c825c47 View commit details
    Browse the repository at this point in the history

  7. cleanup 

    Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
    @macfarla
    macfarla committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    5ebcdac View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' of github.com:hyperledger/besu into chain-height-… 

    …estimate-tolerance
    @macfarla
    macfarla committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    8f5ac92 View commit details
    Browse the repository at this point in the history

  9. removed unused method 

    Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
    @macfarla
    macfarla committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    7db08e9 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2024

  1. allow 5 trailing peers not 0 

    Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
    @macfarla
    macfarla committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    ea60f72 View commit details
    Browse the repository at this point in the history

  2. add chain height estimate to ethPeer.toString() 

    Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
    @macfarla
    macfarla committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    d3d15f6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:hyperledger/besu into chain-height-… 

    …estimate-tolerance
    @macfarla
    macfarla committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    75da10f View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. logging order 

    Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
    @macfarla
    macfarla committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    efe7a64 View commit details
    Browse the repository at this point in the history

  2. revert change in comparator 

    Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
    @macfarla
    macfarla committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    755d41b View commit details
    Browse the repository at this point in the history

  3. update test 

    Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
    @macfarla
    macfarla committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    2ea6a32 View commit details
    Browse the repository at this point in the history

  4. merge 

    Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
    @macfarla
    macfarla committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    a3dceb4 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of github.com:hyperledger/besu into chain-height-… 

    …estimate-tolerance
    @macfarla
    macfarla committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    20dbba0 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Merge branch 'main' into chain-height-estimate-tolerance

    @gfukushima
    gfukushima committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    2d81237 View commit details
    Browse the repository at this point in the history

  2. use Long.MAX_VALUE to skip the trailingPeer validation, likely incorr… 

    …ectly disconnecting good peers

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
    @gfukushima
    gfukushima committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    8352324 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. Merge branch 'main' of github.com:hyperledger/besu into chain-height-… 

    …estimate-tolerance
    @macfarla
    macfarla committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    47fae0a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'chain-height-estimate-tolerance' of github.com:macfarla… 

    …/besu into chain-height-estimate-tolerance
    @macfarla
    macfarla committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    94f3a3e View commit details
    Browse the repository at this point in the history