Improve Peer Logging #6831
Closed
Improve Peer Logging #6831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
siladu
changed the title
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
gfukushima
reviewed
Mar 28, 2024
| uselessResponseTimes.add(timestamp); | ||
| while (shouldRemove(uselessResponseTimes.peek(), timestamp)) { | ||
| uselessResponseTimes.poll(); | ||
| } | ||
| if (uselessResponseTimes.size() >= USELESS_RESPONSE_THRESHOLD) { | ||
| score -= LARGE_ADJUSTMENT; | ||
| LOG.debug("Disconnection triggered by exceeding useless response threshold"); | ||
| LOG.warn( |
There was a problem hiding this comment.
Did you mean to change this to warn level? Isn't this going to spam the logs?
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
8 tasks
|
closing this as I've combined this with #6924 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Simon Dudley simon.dudley@consensys.net
PR description
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests