New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add receipt compaction option #1555
Add receipt compaction option #1555
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
||
</Tabs> | ||
|
||
Enables or disables receipt compaction. Compacting receipts reduces storage by trimming unnecessary data from transaction receipts. Enabled by default, this option optimizes storage efficiency. It can be disabled if the compaction process introduces performance overhead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enabled by default
Currently it's disabled by default. Also, not released yet, but might be soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be disabled if the compaction process introduces performance overhead.
I'm not sure if this this performance overhead was actually observed but would defer to @jframe. Thinking we don't need to suggest why you might want to disable it, maybe could remove this sentence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree we should remove the sentence about performance. At the moment it's not clear without additional testing in high load environments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion for consistency otherwise lgtm.
Co-authored-by: Alexandra Tran Carrillo <12214231+alexandratran@users.noreply.github.com> Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
Closes #1533