Add receipt compaction option #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
siladu
reviewed
Apr 2, 2024
|
|
||
| </Tabs> | ||
|
|
||
| Enables or disables receipt compaction. Compacting receipts reduces storage by trimming unnecessary data from transaction receipts. Enabled by default, this option optimizes storage efficiency. It can be disabled if the compaction process introduces performance overhead. |
There was a problem hiding this comment.
Enabled by default
Currently it's disabled by default. Also, not released yet, but might be soon.
There was a problem hiding this comment.
It can be disabled if the compaction process introduces performance overhead.
I'm not sure if this this performance overhead was actually observed but would defer to @jframe. Thinking we don't need to suggest why you might want to disable it, maybe could remove this sentence?
There was a problem hiding this comment.
Agree we should remove the sentence about performance. At the moment it's not clear without additional testing in high load environments.
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
jframe
approved these changes
May 1, 2024
alexandratran
approved these changes
May 2, 2024
Co-authored-by: Alexandra Tran Carrillo <12214231+alexandratran@users.noreply.github.com> Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1533