Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

fix: Docker warning when using frapsoft/openssl on arm64 system #3374

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DRK3
Copy link
Contributor

@DRK3 DRK3 commented Sep 15, 2022

Resolved a warning from Docker that would get printed when running the generate-test-keys Makefile target on an arm64 system. The warning from Docker alerts you that the image for frapsoft/openssl is for amd64, which doesn't match the system you're on (when using an arm64-based OS). To resolve the warning, you have to either use an image that matches the system architecture, or explicitly state the platform using the --platform flag. In this case, there is only an amd64 version of frapsoft/openssl, so I added the explicit flag to resolve the warning. I also added a TODO for us to find an arm64 alternative in the future (although the amd64 version of frapsoft/openssl does work fine on arm64 macOS currently as it seems that Docker makes use of QEMU to support emulation of non-native architectures).

Signed-off-by: Derek Trider Derek.Trider@securekey.com

@DRK3 DRK3 force-pushed the ResolveDockerWarningOpenSSLARM branch from 80a264c to a9798a4 Compare September 15, 2022 20:51
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #3374 (7ccc688) into main (368f53b) will decrease coverage by 0.00%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##             main    #3374      +/-   ##
==========================================
- Coverage   87.57%   87.56%   -0.01%     
==========================================
  Files         343      343              
  Lines       46809    46832      +23     
==========================================
+ Hits        40994    41010      +16     
- Misses       4318     4323       +5     
- Partials     1497     1499       +2     
Impacted Files Coverage Δ
...to/primitive/aead/aes_cbc_hmac_aead_key_manager.go 90.74% <ø> (ø)
...tinkcrypto/primitive/bbs/bbs_signer_key_manager.go 83.46% <ø> (ø)
...nkcrypto/primitive/bbs/bbs_verifier_key_manager.go 100.00% <ø> (ø)
...composite/ecdh/ecdh_nistpkw_private_key_manager.go 90.07% <ø> (ø)
.../composite/ecdh/ecdh_nistpkw_public_key_manager.go 88.88% <ø> (ø)
...omposite/ecdh/ecdh_x25519kw_private_key_manager.go 82.94% <ø> (ø)
...composite/ecdh/ecdh_x25519kw_public_key_manager.go 88.88% <ø> (ø)
...imitive/composite/register_ecdh_aead_enc_helper.go 87.94% <ø> (ø)
...rimitive/secp256k1/secp256k1_signer_key_manager.go 82.90% <ø> (-2.57%) ⬇️
...mitive/secp256k1/secp256k1_verifier_key_manager.go 65.71% <ø> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@DRK3 DRK3 force-pushed the ResolveDockerWarningOpenSSLARM branch 2 times, most recently from ef72835 to 55fa969 Compare October 4, 2022 20:11
@DRK3
Copy link
Contributor Author

DRK3 commented Oct 4, 2022

@rolsonquadras Can you merge? The unit test failure appears to be some intermittent failure happening in AFGo.

@DRK3 DRK3 force-pushed the ResolveDockerWarningOpenSSLARM branch from 55fa969 to ded7f57 Compare October 26, 2022 20:25
Resolved a warning from Docker that would get printed when running the generate-test-keys Makefile target on an arm64 system. The warning from Docker alerts you that the image for frapsoft/openssl is for amd64, which doesn't match the system you're on (when using an arm64-based OS). To resolve the warning, you have to either use an image that matches the system architecture, or explicitly state the platform using the --platform flag. In this case, there is only an amd64 version of frapsoft/openssl, so I added the explicit flag to resolve the warning. I also added a TODO for us to find an arm64 alternative in the future (although the amd64 version of frapsoft/openssl does work fine on arm64 macOS currently as it seems that Docker makes use of QEMU to support emulation of non-native architectures).

Signed-off-by: Derek Trider <Derek.Trider@securekey.com>
@DRK3 DRK3 force-pushed the ResolveDockerWarningOpenSSLARM branch from ded7f57 to 7ccc688 Compare November 1, 2022 20:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants