Clean up connections after websocket close #3352
Conversation
| @@ -79,9 +79,7 @@ func (d *connPool) remove(verKey string) { | |||
| } | |||
|
|
|||
| func (d *connPool) listener(conn *websocket.Conn, outbound bool) { | |||
| verKeys := []string{} | |||
There was a problem hiding this comment.
These never get populated.
|
If you like the approach, or if it's acceptable, then I can try to add tests. |
borancar
force-pushed
the
fix/wsconn_close
branch
from
a02a1b2
to
f0f25d1
Compare
Make sure we clean up connections by just going through the map and cleaning all the verkeys that match the connection. This is a suboptimal solution, but a connection close is not something happennig often. Signed-off-by: Boran Car <boran.car@gmail.com>
borancar
force-pushed
the
fix/wsconn_close
branch
from
f0f25d1
to
ffa35a9
Compare
Codecov Report
@@ Coverage Diff @@
## main #3352 +/- ##
==========================================
- Coverage 87.89% 87.84% -0.06%
==========================================
Files 330 330
Lines 45571 45633 +62
==========================================
+ Hits 40056 40087 +31
- Misses 4085 4110 +25
- Partials 1430 1436 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The unused check is incorrect (or possibly incomplete as it doesn't take the regular server into account), it's used here https://github.com/hyperledger/aries-framework-go/blob/b1decdfed852057fe64660b40ac705953b4d6d0f/pkg/didcomm/transport/ws/upgrade_srv.go#L28-L35 |
Title:
Clean up connections after WebSocket close
Description:
Make sure we clean up connections by just going through the map and
cleaning all the verkeys that match the connection. This is a suboptimal
solution, but a connection close is not something happening often.
Fixes #3349