Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add Temperture adjustment #1710

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Lord-Grey
Copy link
Collaborator

@Lord-Grey Lord-Grey commented Mar 3, 2024

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

image

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:
Fixes #658
Fixes #1410

@Lord-Grey Lord-Grey self-assigned this Mar 3, 2024
@Lord-Grey Lord-Grey added this to In Progress in Core Mar 3, 2024
@Lord-Grey Lord-Grey added this to In Progress in Web UI Mar 3, 2024
@Rastafabisch
Copy link
Contributor

I've got a further suggestion: Automatically apply such temperature adjustments based on the OS night mode filter. This would apply to any desktop OS like Linux' Gnome, KDE, Windows 10 & 11 and macOS since Sierra (10.12).

@Lord-Grey
Copy link
Collaborator Author

@kopidoo Maybe you could check, if this PR addresses the issue #1410 you raised before.
@Rastafabisch Before we discuss features on top of this feature, would you mind testing, if it works in general?

You could test the PR on without building yourself, following the
Testing Pull Requests documentation.


// Constants
namespace {
const int TEMPERATURE_MINIMUM = 1000;

Check notice

Code scanning / CodeQL

Unused static variable Note

Static variable TEMPERATURE_MINIMUM is never read.
// Constants
namespace {
const int TEMPERATURE_MINIMUM = 1000;
const int TEMPERATUR_MAXIMUM = 40000;

Check notice

Code scanning / CodeQL

Unused static variable Note

Static variable TEMPERATUR_MAXIMUM is never read.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Core
  
In Progress
Web UI
  
In Progress
Development

Successfully merging this pull request may close these issues.

Simple color temperature slider Transform "Color Temperature" missing
2 participants