Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merge blocked] [#4733] prevent download when unauthenticated #4835

Draft
wants to merge 18 commits into
base: develop
Choose a base branch
from
Draft

[Merge blocked] [#4733] prevent download when unauthenticated #4835

wants to merge 18 commits into from
+179 −23

Conversation

devincowan
Copy link
Contributor

@devincowan devincowan commented Nov 15, 2022 •
edited

Resolves #4733

Pull Request Checklist:

  • Positive Test Case Written by Dev
  • Automated Testing
  • Sufficient User and Developer Documentation
  • Passing Jenkins Build
  • Peer Code review and approval

Positive Test Case

  1. Create a public resource
  2. Log out of HS
  3. Attempt to download the resource file(s) using
    • Full zipped bag
    • Single file (file browser menu button)
    • Single file (right click context menu)
    • API
  4. In all cases, modal requesting login/singup is shown

@hydrocheck
Copy link
Collaborator

METRIC VALUE

https://sonarqube.cuahsi-workstation.com:9000/dashboard?id=hydroshare-4835

@devincowan devincowan changed the title [#4733] prevent download when unauthenticated [Merge blocked] [#4733] prevent download when unauthenticated Nov 16, 2022
@devincowan
Copy link
Contributor Author

@sblack-usu FYI we are targeting this for release early 2023 so no rush to review, thanks!

@devincowan devincowan removed the request for review from sblack-usu November 30, 2022 15:07
@devincowan devincowan marked this pull request as draft November 30, 2022 15:07
@devincowan devincowan mentioned this pull request Jan 27, 2023
Open
devincowan
devincowan commented Mar 2, 2023
View reviewed changes
hs_tracking/middleware.py Outdated Show resolved Hide resolved
@devincowan devincowan marked this pull request as ready for review March 16, 2023 14:48
@devincowan devincowan marked this pull request as draft March 29, 2023 15:35
@devincowan devincowan removed the request for review from sblack-usu May 1, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Require user to be logged in to download from HydroShare
2 participants
@devincowan @hydrocheck