Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth: Better OAuth #722

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

OAuth: Better OAuth #722

wants to merge 5 commits into from

Conversation

air-adteam
Copy link

@air-adteam air-adteam commented Jan 25, 2024

Add platform name recognition fields for the use of multiple OAuth modules.

@undefined-moe
Copy link
Member

So what's this new column for?

@air-adteam
Copy link
Author

air-adteam commented Jan 27, 2024

So what's this new column for?

Record the name of the platform. For example, QQ and GitHub make a distinction to pave the way for the later template to show the platform binding.

However, in order to be compatible with early plug-ins, the "platform" here is made an optional attribute, and the plug-ins developed later are recommended to register the platform name (the "platform" field is added to the operation to mark the platform name)

@undefined-moe
Copy link
Member

Then implement it. Don't do things by half.

@air-adteam
Copy link
Author

Then implement it. Don't do things by half.

Yes, there is a three-step plan here: 1. Update the API within Hydrooj. 2. Update the template. 3. Update other official plugins. Currently, the API section has been updated, and I believe that changing these should be the first step completed.

@undefined-moe
Copy link
Member

There's no breaking change so no need to do it step by step. It can be implemented altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants