Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New look and funcions for editor and quick override fix #74

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

esnho
Copy link

@esnho esnho commented Jan 25, 2020

Hi Olivia,

thank you for your wonderful synth.

I'd like to propose few changes to the editor, obviously is just a proposal and if necessary I can change my edits or cancel the pull request.

And a fix to keydown listener:

Here a screenshot of the editor with these changes:
Preview

@esnho esnho requested a review from ojack January 25, 2020 11:59
@ojack
Copy link
Member

ojack commented Jan 25, 2020

Hi,

I really like the highlighting of brackets and auto close brackets!

Some changes before merging this:

  • -- switch the key commands to the keymaps.js file (this is to make it easier to automate and configure key commands, as well as implement different editors down the line)
  • -- the autocomplete does not contain relevant information... it would be really nice to include if it works! for now i think we should leave it out.

There are some style things that are too heavy handed for me. It is complicated in hydra because there is a trade off between readability and blocking the visuals.:
Things that I would like to keep as is (how they were before):

  • the error log
  • get rid of the black line that appears at the beginning of each empty line
  • the cursor

I really like the line highlighting, but I think it can be really intrusive. A lot of ppl perform with hydra by making the code really small in a large window, and this would cause a line across the whole screen. I would be interested in just highlighting the line in the left hand gutter.

I think the bracket highlighting could be a more muted grey to not get so confused with the cursor.

Maybe this is a good chance to think about allowing custom theming and editor configuration, because I am sure ppl will have different preferences in different scenarios.

@esnho
Copy link
Author

esnho commented Jan 26, 2020

Hey @ojack , thank you for the feedback.

I made up changes and used the left hand gutter to highlight selected line.

If necessary I can rollback to no selected line highlight as before :)

preview

Base automatically changed from master to main February 28, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants