fix a security issue w/ file names and git publishing... #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use shell, and ensure that file names, like: "; touch /tmp/securityissue; " Won't cause an issue...
|
Some of these failures have nothing to do w/ my code. I cannot control/install asciidocapi on the machine to fix job 99.1. Some of the failures in job 99.5 are not mine. Job 99.6 failure is related to failure to maintain and again, unrelated to my changes. |
|
I can't verify if the checks are failing due to the issues resolved in #329 because travis CI is down. I will pull and rebase this branch off the current 0.9.0 branch and if it passes the tests off that branch when travis is back up I will merge it in. |
Descent098
added
the
Maintainer Task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use shell, and ensure that file names, like:
"; touch /tmp/securityissue; "
Won't cause an issue...