Make the tagger archive path os independent #244
Conversation
Solution to issue #235 - regardless of the separator used, it will work in windows and unix environments.
|
Tested on windows. |
Need that too.
| @@ -376,7 +377,8 @@ def _create_tag_archive(self, config): | |||
| raise HydeException("No Template specified in tagger configuration.") | |||
| content = self.site.content.source_folder | |||
| source = Folder(config.get('source', '')) | |||
| target = content.child_folder(config.get('target', 'tags')) | |||
| target_prop = os.path.join(*re.split('[\\/]', config.get('target', 'tags'))) | |||
There was a problem hiding this comment.
Be carefull here! You are splitting with re's both \ and / but joining with os.path.
It also would be nice that such platform dependency should be hidden inside "child_folder" or config.get() (get_path()?). Either way, you should do that for every path you get from config or you pass it to a child_folder.
There was a problem hiding this comment.
I suspect you are probably right about the child_folder note - although you have to watch that links stay the web way, and only Windows FS paths go the Windows way.
Hmm - the split/join operation needs to be translating one OS separator to the other.
I am not sure about the legality of forward slashes in unix file names or backslashes in windows file names. I may be in danger here of assuming that they are not legal in them - and besides - if shared via source control, dropbox or some other means between them - it would be a problem there too - so this should be a safe assumption.
Solution to issue #235 - regardless of the separator used, it will work in windows and unix environments.