Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make username optionnal in ssh publisher (FIX) #231

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maethor
Copy link
Contributor

@maethor maethor commented Aug 20, 2013

The patch submitted in #222 was not enough to fix the problem. This patch fix the forgotten line.

I apologize for the inconvenience. This one has been tested.

@pjakobsen
Copy link

Good to have the username option, but what about using SSH on non- standard ports, eg. ssh -p 7822. I've tried

opts: -r -e ssh -p 7822

but no luck there.

@pjakobsen
Copy link

Turns out you can rsync to non-standard point by simply putting quotes around the ssh command, as follows:

......
command: rsync
opts: -r -e "ssh -p 7822"

@llonchj
Copy link
Contributor

llonchj commented May 23, 2015

Thanks @maethor Please fix the commit to the suggested self.username = getattr(settings, 'username', '') and, if possible write some unittest for the case to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants