-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gh pages #8
base: master
Are you sure you want to change the base?
Gh pages #8
Conversation
adding requirements.txt and fixing sphinx build command installing pipenv, via system pip3, into user venv. also installing setuptools also installing wheel for python3 specifically installing python 3.7
.github/workflows/main.yml
Outdated
push: | ||
branches: [ master ] | ||
pull_request: | ||
branches: [ master ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand this correctly, these two lines should be removed before merging otherwise any PR to master would update the docs.
The way tokens work though I believe this is true only for PRs opened where the author has commit rights to the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point... I m just discovering github actions, but maybe we want 2 workflows:
- one for pull request that just attempt a build (doctests and other can be added later on)
- one for push that build and deploy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now the way it works is that any change to master rebuilds the Alloy docs on readthedocs.
My main concern here is with conf.py: https://github.com/hwayne/alloydocs/blob/master/conf.py#L187. The intent there is to hide (We'd also need to make sure that this merge wouldn't break the RTD documentation, as that's where we're hosting the provision docs. Merging the github actions building would be more to make sure we could incorporate it seamlessly into the rest of the docs when the time is right.) |
We can use a github defined variable like I also setup a build on RTD : |
My personal concern however is with the python virtual environment setup. My personal choice for all my projects currently is pipenv, and it looks like RTD has had some discussion about it : readthedocs/readthedocs.org#3181 However I don't see it used at all in the build : https://readthedocs.org/projects/alloydocs-fork/builds/10889123/ I think we would still need a |
A simple attempt to integrate sphinx doc with github pages.