Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui not deleted when uninstall #132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

panguicai008
Copy link

No description provided.

Signed-off-by: panguicai008 <guicai.pan@daocloud.io>
@SSmallMonster
Copy link
Member

@panguicai008 Thanks for your contribution.

This is good for me, but there are some change about indentation, can we fix it at another PR?

@panguicai008
Copy link
Author

panguicai008 commented Jun 8, 2023

@panguicai008 Thanks for your contribution.

This is good for me, but there are some change about indentation, can we fix it at another PR?

there are some change about indentation,this means that the code has not been formatted. Do I need to leave a formatted mistake uncorrected, and only change my part?

@SSmallMonster
Copy link
Member

@panguicai008 Thanks for your contribution.
This is good for me, but there are some change about indentation, can we fix it at another PR?

there are some change about indentation,this means that the code has not been formatted. Do I need to leave a formatted mistake uncorrected, and only change my part?

I think so, may be we should format all files , how do you think @buffalo1024 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants