#![no_std] as an optional feature #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@huonw any chance of merging? I was working on no-std support for another crate and this is a dependency. I would appreciate the changes being published to crates.io so that the downstream crate can also be published. |
|
I can help with changes in this repo, but I don't have access to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes primal available on no_std targets by adding no-std feature.
I have checked this builds on thumbv7em-none-eabihf.
I ran cargo bench before and after those changes and found no difference in performance (tested on x86_64-linux-gnu).
Without the no-std feature enabled the crate still builds on the MSRV (1.36).
One issue I found is the hamming dependency - no_std support was added there 5 years ago, but the newest version on crates.io is from 8 years ago.