Add "new with at least n primes" function to Sieve #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
Woo, thanks. I haven't come up with any other names I like yet... |
|
Yes, neither have I. The best I've thought of is |
|
☔ The latest upstream changes (presumably 6806007) made this pull request unmergeable. Please resolve the merge conflicts. |
wackywendell
force-pushed
the
at_least
branch
from
a43e7c7
to
58dea75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a function to
Sieveto create a newSieveinstance that has at leastnprimes in it, for a given value ofn.This also adds an implementation of
IteratorandIntoIteratorforSieve, just for convenience.As discussed in #3, the name
new_at_leastis pretty terrible, but I couldn't come up with anything better. I'm hoping for suggestions!