Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileIO Sendable fixes and minor API changes #401

Merged
merged 4 commits into from Mar 16, 2024
Merged

FileIO Sendable fixes and minor API changes #401

merged 4 commits into from Mar 16, 2024

Conversation

adam-fowler
Copy link
Member

  • Don't pass around unsendable FileHandler.
  • Use ClosedRanges instead of FileRegions which are also unsendable
  • FileIO.writeFile can write a generic AsyncSequence instead of just a RequestBody
  • Remove usage of EventLoops in FileIO

@adam-fowler adam-fowler merged commit 0f30aee into main Mar 16, 2024
4 of 5 checks passed
@adam-fowler adam-fowler deleted the fileio-fixes branch March 16, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joannis Joannis Joannis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adam-fowler @Joannis