Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket extensions and permessage-deflate extension #45

Merged
merged 9 commits into from Mar 29, 2024

Conversation

adam-fowler
Copy link
Member

No description provided.

Copy link
Contributor

@Joannis Joannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you've tested this against a third-party implementation as well? If possible, I think we should add a test to verify what happens when there are two different websocket extension at play.

adam-fowler and others added 5 commits March 26, 2024 09:56
Co-authored-by: Joannis Orlandos <joannis@orlandos.nl>
Co-authored-by: Joannis Orlandos <joannis@orlandos.nl>
Co-authored-by: Joannis Orlandos <joannis@orlandos.nl>
Co-authored-by: Joannis Orlandos <joannis@orlandos.nl>
Co-authored-by: Joannis Orlandos <joannis@orlandos.nl>
@adam-fowler
Copy link
Member Author

I assume you've tested this against a third-party implementation as well? If possible, I think we should add a test to verify what happens when there are two different websocket extension at play.

The snippet enables permessage-deflate and you can check it against your web browser.
testPerMessageExtensionOrdering checks what happens when you have two extensions in play.

@adam-fowler adam-fowler merged commit 541324e into main Mar 29, 2024
3 of 4 checks passed
@adam-fowler adam-fowler deleted the permessage-deflate branch March 29, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants