Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup API #42

Merged
merged 7 commits into from Mar 22, 2024
Merged

Cleanup API #42

merged 7 commits into from Mar 22, 2024

Conversation

adam-fowler
Copy link
Member

  • WebSocketDataHandler is no longer a protocol, it is just a closure
  • Removed generic parameters from WebSocketClientChannel and HTTP1AndWebSocketChannel

@@ -11,7 +11,7 @@ let package = Package(
// .library(name: "HummingbirdWSCompression", targets: ["HummingbirdWSCompression"]),
],
dependencies: [
.package(url: "https://github.com/hummingbird-project/hummingbird.git", from: "2.0.0-beta.1"),
.package(url: "https://github.com/hummingbird-project/hummingbird.git", branch: "main"),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted to main temporarily until beta 2 is released

Copy link
Contributor

@Joannis Joannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One discussion topic

Tests/HummingbirdWebSocketTests/WebSocketTests.swift Outdated Show resolved Hide resolved
@adam-fowler adam-fowler merged commit 0f61374 into main Mar 22, 2024
3 of 4 checks passed
@adam-fowler adam-fowler deleted the cleanup-api branch March 22, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants