Use migration system for JobQueue and Persist frameworks #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joannis
requested changes
Mar 7, 2024
|
|
||
| extension HBMigrationGroup { | ||
| /// JobQueue migration group | ||
| public static var jobQueue: Self { .init("_hb_jobqueue") } |
There was a problem hiding this comment.
Isn't this better off as such:
Suggested change
| public static var jobQueue: Self { .init("_hb_jobqueue") } | |
| public static var jobQueue: Self { .init("_hb_pg_jobqueue") } |
| @@ -180,7 +166,7 @@ public final class HBPostgresQueue: HBJobQueueDriver { | |||
| } | |||
| // select job from job table | |||
| let stream2 = try await connection.query( | |||
| "SELECT job FROM \(unescaped: self.configuration.jobTable) WHERE id = \(jobId)", | |||
| "SELECT job FROM _hb_jobs WHERE id = \(jobId)", | |||
There was a problem hiding this comment.
These tables should probably be namespaced to pg right?
|
|
||
| extension HBMigrationGroup { | ||
| /// Persist driver migration group | ||
| public static var persist: Self { .init("_hb_persist") } |
There was a problem hiding this comment.
Likewise
Suggested change
| public static var persist: Self { .init("_hb_persist") } | |
| public static var persist: Self { .init("_hb_pg_persist") } |
Joannis
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also
HBMigrations.revert()no longer sets the migrations to be complete.