2.x.x: Fix multi-value query values and headers for APIGatewayV2 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-fowler
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x.x #24 +/- ##
==========================================
- Coverage 89.95% 85.45% -4.50%
==========================================
Files 8 8
Lines 209 220 +11
==========================================
Hits 188 188
- Misses 21 32 +11 ☔ View full report in Codecov by Sentry. |
adam-fowler
changed the title
adam-fowler
force-pushed
the
2.x.x-query-values
branch
from
56c3faf
to
593a3cc
Compare
Joannis
approved these changes
Mar 7, 2024
adam-fowler
added a commit
that referenced
this pull request
Mar 12, 2024
* Fix multi-value query values in APIGatewayV2 * Add support for multivalue headers in APIGatewayV2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new protocol requirements for APIRequest which return the query string and http headers in a generic form. Implement both of these for APIGatewayRequest and APIGatewayV2Request
There are no tests in this PR as the tests are in the XCTest PR #25 and adding any here will just produce merge issues